> > >> + cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE); >> + memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len); >> + if (cdb_len < MAX_CDB_SIZE) >> + memset(ucd_req_ptr->sc.cdb + cdb_len, 0, >> + (MAX_CDB_SIZE - cdb_len)); > It's just 16 bytes, setting all to zero prior to copy will be as good as > this if statement > memset(ucd_req_ptr->sc.cdb, 0, MAX_CDB_SIZE); > i agree. will be modified in V7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
