Re: [PATCH v2 02/11] qla2xxx: Seed init-cb login timeout from nvram exclusively.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 27, 2016 at 12:03:29PM -0500, Himanshu Madhani wrote:
> From: Joe Carnuccio <joe.carnuccio@xxxxxxxxxx>
> 
> Signed-off-by: Joe Carnuccio <joe.carnuccio@xxxxxxxxxx>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> ---
>  drivers/scsi/qla2xxx/qla_init.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 52a8765..a663ff6 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -2844,7 +2844,6 @@ qla2x00_nvram_config(scsi_qla_host_t *vha)
>  	if (nv->login_timeout < 4)
>  		nv->login_timeout = 4;
>  	ha->login_timeout = nv->login_timeout;
> -	icb->login_timeout = nv->login_timeout;
>  
>  	/* Set minimum RATOV to 100 tenths of a second. */
>  	ha->r_a_tov = 100;
> @@ -5274,7 +5273,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha)
>  	if (le16_to_cpu(nv->login_timeout) < 4)
>  		nv->login_timeout = cpu_to_le16(4);
>  	ha->login_timeout = le16_to_cpu(nv->login_timeout);
> -	icb->login_timeout = nv->login_timeout;
>  
>  	/* Set minimum RATOV to 100 tenths of a second. */
>  	ha->r_a_tov = 100;
> @@ -6231,7 +6229,6 @@ qla81xx_nvram_config(scsi_qla_host_t *vha)
>  	if (le16_to_cpu(nv->login_timeout) < 4)
>  		nv->login_timeout = cpu_to_le16(4);
>  	ha->login_timeout = le16_to_cpu(nv->login_timeout);
> -	icb->login_timeout = nv->login_timeout;
>  
>  	/* Set minimum RATOV to 100 tenths of a second. */
>  	ha->r_a_tov = 100;
> -- 
> 1.7.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

You really should be a bit more verbose in your commit messages...

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux