On 18.12.2015 14:27, Sumit Saxena wrote: > This patch will introduce module-parameter for SCSI command timeout value and fix setting of resetwaitime beyond a value. > > Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxxx> > Signed-off-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxxx> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 15 ++++++++++++--- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index cc843d6..316d5a0 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -83,7 +83,7 @@ module_param(throttlequeuedepth, int, S_IRUGO); > MODULE_PARM_DESC(throttlequeuedepth, > "Adapter queue depth when throttled due to I/O timeout. Default: 16"); > > -int resetwaittime = MEGASAS_RESET_WAIT_TIME; > +unsigned int resetwaittime = MEGASAS_RESET_WAIT_TIME; > module_param(resetwaittime, int, S_IRUGO); > MODULE_PARM_DESC(resetwaittime, "Wait time in seconds after I/O timeout " > "before resetting adapter. Default: 180"); > @@ -100,6 +100,10 @@ unsigned int dual_qdepth_disable; > module_param(dual_qdepth_disable, int, S_IRUGO); > MODULE_PARM_DESC(dual_qdepth_disable, "Disable dual queue depth feature. Default: 0"); > > +unsigned int scmd_timeout = MEGASAS_DEFAULT_CMD_TIMEOUT; > +module_param(scmd_timeout, int, S_IRUGO); > +MODULE_PARM_DESC(scmd_timeout, "scsi command timeout (10-90s), default 90s. See megasas_reset_timer."); When you know that "The RAID firmware may require extended timeouts" what do you expect when an user sets a short timeout value ? Other than that, I don't think that lot of tunables in a driver makes it better, from my point of view you could remove both resetwaittime + scmd_timeout. Okay, I don't want to stay in the way if you really need it so - Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx> Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
