> @@ -335,6 +336,10 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h, > int rel_port = -1, group_id; > struct alua_port_group *pg, *old_pg = NULL; > bool pg_updated = false; > + unsigned int bflags = scsi_get_device_flags_keyed(sdev, > + &sdev->inquiry[8], > + &sdev->inquiry[16], > + SCSI_DEVINFO_GLOBAL); I see not reason to use scsi_get_device_flags_keyed over scsi_get_device_flags here. Also: - why can't we just set a flag in the sdev like for most other blacklist item (in the long run I plan to simply mirror all blist flags into the sdev anyway). - please add the affected arrays to scsi_static_device_list -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
