Device is not becoming offline on failed TUR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

We have a virtual target that under some circumstances returns HARDWARE_ERROR (4/44) on TUR. Previously on initiator side scsi_check_sense() returned TARGET_ERROR, that in scsi_eh_tur() was converted to 1 (device not ready). And then scsi_eh_ready_devs() called scsi_eh_offline_sdevs to move device to the OFFLINE state.

In commit http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=87f14e6 this logic has been changed. Now on HARDWARE_ERROR scsi_check_sense() only sets DID_TARGET_FAILURE and returns SUCCESS. As a result device remains "running", and scsi_eh_flush_done_q() doesn't finish the command but retries it. So in this case it takes for the stuck command much more time to finish.

Am I missing something? Is it a bug or intentional new behavior?

Thanks,
Lev.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux