On Wed, Jan 13, 2016 at 08:13:54AM +0100, Hannes Reinecke wrote: >> _Actually_ we only need to call flush_delayed_work if sdev == >> rtgp_sdev. Otherwise the workqueue item is running off a different >> device and won't be affected. >> > Hmm. Well, not quite. We run into flush_delayed_work() only if the port > group changes or upon bus detach. > For all other callers rtpg_sdev() should already be NULL. > But looking at the call sites we can indeed move the flush_delayed_work() > into the release function. Looks like the earlier you made sense after all :) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html