Hi, On 1/8/2016 2:20 PM, Akinobu Mita wrote: > 2016-01-07 18:44 GMT+09:00 Christoph Hellwig <hch@xxxxxxxxxxxxx>: >>> This driver patch includes a core driver and glue drivers for pci and platform >>> for the DesignWare UFS Host IP. >> >> Why doesn't this use the existing ufs core? The architecture looks >> completely backwards to me. > > I agree. The existing ufs driver can have variant specific operations > (hba->vops) and also can define quirks. So if DesignWare UFS host > controller requires vendor specific register settings or DME operations > in initialization, or needs special workarounds for the specific versions, > it can use those mechanisms and shares common parts between other host > controllers. > I agree with you. We're already engaging internally a patch rework and so there will be a new patch soon based on your comments. Thank you for your comments. Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
