On Fri, Jan 08, 2016 at 07:15:46AM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > With the changes in place to obtain se_node_acl->acl_kref > from within core_tpg_del_initiator_node_acl() and auditing > existing users, it's clear there is no need to perform the > lookup during core_tpg_set_initiator_node_queue_depth(). > > This is because se_node_acl->acl_group is already protecting > the se_node_acl reference via configfs, and ->acl_group > shutdown in core_tpg_del_initiator_node_acl() can't occur > until core_tpg_set_initiator_node_queue_depth() completes. > > Also, remove a related pointless wrapper in iscsi-target. While we're at it, can you please remove the always true force argument from core_tpg_set_initiator_node_queue_depth and rename the funcion to something like target_set_initiator_node_queue_depth. Btw, what's the use case for modifying this on a 'live' session that gets shutdown for that purpose? The whole algorithm looks somewhat fishy to me to be honest. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
