If the time is actually in jiffies already it seems cleaner to call schedule_timeout_interruptible() than to call msleep and covert the timeout. In this case it will actually optimize the code a bit as it does not need to call jiffies_to_msecs here. Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx> --- problem was found by coccinelle spatch patch was compile tested with: x86_64_defconfig + CONFIG_CHR_DEV_OSST=m patch is against linux-next (localversion-next is -next-20160107) drivers/scsi/osst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 5033223..d8e5aa9 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -760,7 +760,7 @@ static int osst_wait_ready(struct osst_tape * STp, struct osst_request ** aSRpnt #endif if (initial_delay > 0) - msleep(jiffies_to_msecs(initial_delay)); + schedule_timeout_uninterruptible(initial_delay); memset(cmd, 0, MAX_COMMAND_SIZE); cmd[0] = TEST_UNIT_READY; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
