James Bottomley wrote: > On Wed, 2016-01-06 at 09:24 +0100, Bart Van Assche wrote: > > Instead of representing the states "visible in sysfs" and > > "has been removed from the target list" by a single state > > variable, use two variables to represent this information. > > > > This patch avoids that SCSI device removal can trigger a > > soft lockup. > > It does? When I asked you this the last time, you said the soft lockup > was fixed by a prior patch: > > http://thread.gmane.org/gmane.linux.scsi/107248 > > If you've actually caught a problem, can we have details because the > distro people will want to know what gets fixed by this. > > Thanks, > > James Which details do you need? > > See also: > > * "scsi: restart list search after unlock in scsi_remove_target" > > (commit 40998193560d). > > * "scsi_remove_target: fix softlockup regression on hot remove" > > (commit bc3f02a795d3). > > > > Reported-by: Sebastian Herbszt <herbszt@xxxxxx> > > Tested-by: Sebastian Herbszt <herbszt@xxxxxx> > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: Johannes Thumshirn <jthumshirn@xxxxxxx> > > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > > Cc: stable <stable@xxxxxxxxxxxxxxx> > > --- > > drivers/scsi/scsi_scan.c | 31 +++---------------------------- > > drivers/scsi/scsi_sysfs.c | 7 ++++--- > > include/scsi/scsi_device.h | 9 ++------- > > 3 files changed, 9 insertions(+), 38 deletions(-) > > > > See also: > > - http://thread.gmane.org/gmane.linux.scsi/107245. I was able to hit a soft lockup and reported it here: > > - http://thread.gmane.org/gmane.linux.scsi/108614. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
