On Sat, 2 Jan 2016, Joe Perches wrote:
> On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote:
> > Hanging indentation was a poor choice for the text inside comments. It
> > has been used in the wrong places and done badly elsewhere. There is
> > little consistency within any file. One fork of the core driver uses
> > tabs for this indentation while the other uses spaces. Better to use
> > flush-left alignment throughout.
> >
> > This patch is the result of the following substitution. It replaces tabs
> > and spaces at the start of a comment line with a single space.
> >
> > perl -i -pe 's,^(\t*[/ ]\*)[ \t]+,$1 ,' drivers/scsi/{atari_,}NCR5380.c
> >
> > This removes some unimportant discrepancies between the two core driver
> > forks so that the important ones become obvious, to facilitate
> > reunification.
>
> I still think this patch is poor at best and
> overall not useful.
Opinions will differ.
> @@ -32,15 +32,15 @@
> > /*
> > * Further development / testing that should be done :
> > * 1. Cleanup the NCR5380_transfer_dma function and DMA operation complete
> > - * code so that everything does the same thing that's done at the
> > - * end of a pseudo-DMA read operation.
> > + * code so that everything does the same thing that's done at the
> > + * end of a pseudo-DMA read operation.
> > *
> > * 2. Fix REAL_DMA (interrupt driven, polled works fine) -
> > - * basically, transfer size needs to be reduced by one
> > - * and the last byte read as is done with PSEUDO_DMA.
> > + * basically, transfer size needs to be reduced by one
> > + * and the last byte read as is done with PSEUDO_DMA.
> > *
> > * 4. Test SCSI-II tagged queueing (I have no devices which support
> > - * tagged queueing)
> > + * tagged queueing)
>
> Numbering 1, 2, then 4 could be improved.
That would be churn. I have other plans for the To Do list. The numbering
will get fixed as items are removed.
--
