Re: [PATCH 08/20] scsi_dh_alua: use unique device id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/30/2015 12:20 PM, Christoph Hellwig wrote:
On Tue, Dec 08, 2015 at 08:37:28AM +0100, Hannes Reinecke wrote:
Use scsi_vpd_lun_id() to assign a unique device identification
to the alua port group structure.

I really hate the fix length arrays and how they are passed around.

You and me both.
I would love to be able to identify port group states by a simple 64bit identifier, but SCSI Names throws everything into disarray,

Can't you move the call to scsi_vpd_lun_id into alua_get_pg (alua_alloc_pg)?

Hmm. Think so, yes,

Also I think the new alua_lookup_pg should be alua_find_get_pg or
similar as it takes a reference on the pg.

Sure, no problem with that,

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux