On Wed, Dec 16, 2015 at 07:32:28PM -0500, Martin K. Petersen wrote: > > When somebody posts a patch to a piece of code you maintain it is your > responsibility to respond to it. That's what being a maintainer means. > > There are a ton of trivial/Coccinelle fixes posted that nobody has done > anything about. I'm not talking about spelling fixes or whitespace > churn. Many of these patches look valid to me. There are also a few > non-trivial patches that have gotten no attention from the relevant > driver maintainers. > > People such as Hannes, Johannes, Tomas and Christoph are reviewing > *your* submissions, providing the mandatory impartial review tag that > permits your patches to go into the main tree. > > You can not rely on these people also taking on the burden of reviewing > third party changes to your code. That really is your job as the driver > maintainer. Every patch that touches code that you own demands a > response from you. Every. Single. Patch. > > We review your changes. You have to review everybody else's. > One more thing. If your patches fix a bug (a good indicator is the word "fix" in the subject or commit message), please add a Fixes: 1234abcf 'Buggy commit' Cc: stable@xxxxxxxxxxxxxxx # vX.Y To the SOB area of your patch. This really makes our lives as distribution maintainers - who have to care about actual users - a _lot_ easier. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
