Re: [PATCH 03/17] lpfc: Added throttle logging support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/2015 12:11 AM, James Smart wrote:

Implemented a throttle on error logging.

Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxxx>
Signed-off-by: James Smart <james.smart@xxxxxxxxxxxxx>
---
  drivers/scsi/lpfc/lpfc.h         |  5 +++
  drivers/scsi/lpfc/lpfc_attr.c    | 18 +++++++++++
  drivers/scsi/lpfc/lpfc_crtn.h    |  1 +
  drivers/scsi/lpfc/lpfc_disc.h    | 11 +++++++
  drivers/scsi/lpfc/lpfc_hbadisc.c | 23 +++++++++++++
  drivers/scsi/lpfc/lpfc_init.c    | 70 ++++++++++++++++++++++++++++++++++++++++
  drivers/scsi/lpfc/lpfc_logmsg.h  | 40 +++++++++++++++++++++++
  drivers/scsi/lpfc/lpfc_scsi.c    | 41 ++++++++++++++++-------
  drivers/scsi/lpfc/lpfc_sli.c     |  7 ++++
  9 files changed, 205 insertions(+), 11 deletions(-)

Weeellll ... that stuff doesn't really belong into the driver.

_If_ that really is an issue it should be moved into a generic helper, as other drivers will have the same problem. There also have been quite some discussions at KS about how to handle high-volume logging traffic; also systemd implements its own handling, too.

So it really needs to be discussed separately, and not implemented within a driver.

Cheers,

Hannes
--
Dr. Hannes Reinecke		               zSeries & Storage
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux