be_mbox_db_ready_wait was changed to remove wait_event_timeout done under spinlock held for port initialization FW commands. The timeout change and unrecoverable error check inside the wait loop were needed to be addressed too. Though spinlock was replaced with mutex in patch 2/9. -----Original Message----- From: Hannes Reinecke [mailto:hare@xxxxxxx] Sent: Monday, December 14, 2015 8:34 PM To: Jitendra Bhivare; linux-scsi@xxxxxxxxxxxxxxx; michaelc@xxxxxxxxxxx Subject: Re: [PATCH 1/9] be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx On 12/14/2015 07:10 AM, Jitendra Bhivare wrote: > From: Jitendra <jitendra.bhivare@xxxxxxxxxxxxx> > > We are taking mbox_lock spinlock which disables pre-emption before we > poll for mbox completion. Waiting there with spinlock held in excess > of 20s will cause soft lockup. > > Actual fix is to change mbox_lock to mutex. Really? I didn't find that in the patch ... > The changes are done in phases. This is the first part. > 1. Changed mgmt_get_all_if_id to use MCC instead of BMBX. > 2. Changed be_mbox_db_ready_wait to busy wait for 12s max and removed > wait_event_timeout. Added error handling code for IO reads. > OPCODE_COMMON_QUERY_FIRMWARE_CONFIG mbox command takes 8s time when > unreachable boot targets are configured. > Why did you modify be_mbox_db_ready_wait(), seeing that you're not using the mailbox interface anymore after this change? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
