On 15/12/15 08:07, Uma Krishnan wrote:
From: Manoj Kumar <manoj@xxxxxxxxxxxxxxxxxx> This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver.
If you do a V3 - this could be better worded in the imperative mood as: "Add a new device ID (0x0600) for a future IBM CXL Flash Adapter card."
As per the design, the Accelerator Function Unit (AFU) for this new IBM CXL Flash Adapter retains the same host interface as the previous generation. For the early prototypes of the new card, the driver with this change behaves exactly as the driver prior to this behaved with the earlier generation card. Therefore, no card specific programming has been added. These card specific changes can be staged in later if needed. Signed-off-by: Manoj N. Kumar <manoj@xxxxxxxxxxxxxxxxxx> Acked-by: Matthew R. Ochs <mrochs@xxxxxxxxxxxxxxxxxx>
Assuming that the final card won't break in a particularly nasty way in the absence of later code changes, all looks good.
Reviewed-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx> -- Andrew Donnellan Software Engineer, OzLabs andrew.donnellan@xxxxxxxxxxx Australia Development Lab, Canberra +61 2 6201 8874 (work) IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
