NCR5380.c is not compliant with the SCSI-2 standard (at least, not with the draft revision 10L that I have to refer to). The selection algorithm in atari_NCR5380.c is correct, so use that. Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> --- The NCR 5380 Family datasheet has a flow chart to support this. Please see http://pdf.datasheetarchive.com/indexerfiles/Scans-001/Scans-0031883.pdf This is another old bug fix that was unfortunately never applied to the original NCR5380.c core driver. --- drivers/scsi/NCR5380.c | 8 +++++++- drivers/scsi/atari_NCR5380.c | 7 ++++--- 2 files changed, 11 insertions(+), 4 deletions(-) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2015-12-06 12:29:46.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2015-12-06 12:29:47.000000000 +1100 @@ -1236,7 +1236,13 @@ static int NCR5380_select(struct Scsi_Ho dprintk(NDEBUG_ARBITRATION, "scsi%d : lost arbitration, deasserting MR_ARBITRATE\n", instance->host_no); return -1; } - NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE | ICR_ASSERT_SEL); + + /* After/during arbitration, BSY should be asserted. + * IBM DPES-31080 Version S31Q works now + * Tnx to Thomas_Roesch@xxxxxxxxxx for finding this! (Roman) + */ + NCR5380_write(INITIATOR_COMMAND_REG, + ICR_BASE | ICR_ASSERT_SEL | ICR_ASSERT_BSY); if (!(hostdata->flags & FLAG_DTC3181E) && /* RvC: DTC3181E has some trouble with this Index: linux/drivers/scsi/atari_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/atari_NCR5380.c 2015-12-06 12:29:46.000000000 +1100 +++ linux/drivers/scsi/atari_NCR5380.c 2015-12-06 12:29:47.000000000 +1100 @@ -1480,9 +1480,10 @@ static int NCR5380_select(struct Scsi_Ho return -1; } - /* after/during arbitration, BSY should be asserted. - IBM DPES-31080 Version S31Q works now */ - /* Tnx to Thomas_Roesch@xxxxxxxxxx for finding this! (Roman) */ + /* After/during arbitration, BSY should be asserted. + * IBM DPES-31080 Version S31Q works now + * Tnx to Thomas_Roesch@xxxxxxxxxx for finding this! (Roman) + */ NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE | ICR_ASSERT_SEL | ICR_ASSERT_BSY); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
