Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> A few things I noticed when looking over this and the previous iterations, which are more notes for future work than an actual comment on this patch: - what lock protects ->visible and ->reaped (or previously ->state)? It seems like the synchronization rules in this code are a little fragile. - why don't we make the target visible as soon as we allocated it? We can still tear it down without a whole more effort even if it is visible. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html