On 2.11.2015 17:54, Don Brace wrote: > On 10/30/2015 09:32 AM, Tomas Henzl wrote: >> RAID_UNKNOWN is used in few other places - raid_level_show for example, > raid_level_show handles physical devices by using "N/A", otherwise it > displays > the RAID level for logical devices. > > Other functions avoid the use of raid_type when the drive is not a RAID > device. > > Or, am I missing your point? Seems that I missed the fact that raid_level_show output is N/A, I thought it would be "RAID-Unknown". Last minor point is that you could replace + dev->raid_level > RAID_UNKNOWN ? "?" : + raid_label[dev->raid_level]); with + dev->raid_level > RAID_UNKNOWN ? raid_label[RAID_UNKNOWN] : + raid_label[dev->raid_level]); but that's not important. Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx> Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
