2015-11-02 8:53 GMT+01:00 Hannes Reinecke <hare@xxxxxxx>:
> On 10/30/2015 03:53 PM, Benjamin Rood wrote:
>> ATTO SAS controllers retrieve the SAS address from the NVRAM in a location
>> different from non-ATTO PMC Sierra SAS controllers. This patch makes the
>> necessary adjustments in order to retrieve the SAS address on these types
>> of adapters.
>>
>> Signed-off-by: Benjamin Rood <brood@xxxxxxxxxxxx>
>> ---
>> drivers/scsi/pm8001/pm8001_init.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
>> index feaf504..fdbfab6 100644
>> --- a/drivers/scsi/pm8001/pm8001_init.c
>> +++ b/drivers/scsi/pm8001/pm8001_init.c
>> @@ -636,6 +636,11 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
>> payload.minor_function = 0;
>> payload.length = 128;
>> }
>> + } else if ((pm8001_ha->chip_id == chip_8070 ||
>> + pm8001_ha->chip_id == chip_8072) &&
>> + pm8001_ha->pdev->subsystem_vendor == PCI_VENDOR_ID_ATTO) {
>> + payload.minor_function = 4;
>> + payload.length = 4096;
>> } else {
>> payload.minor_function = 1;
>> payload.length = 4096;
>> @@ -662,6 +667,11 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
>> else if (deviceid == 0x0042)
>> pm8001_ha->sas_addr[j] =
>> payload.func_specific[0x010 + i];
>> + } else if ((pm8001_ha->chip_id == chip_8070 ||
>> + pm8001_ha->chip_id == chip_8072) &&
>> + pm8001_ha->pdev->subsystem_vendor == PCI_VENDOR_ID_ATTO) {
>> + pm8001_ha->sas_addr[j] =
>> + payload.func_specific[0x010 + i];
>> } else
>> pm8001_ha->sas_addr[j] =
>> payload.func_specific[0x804 + i];
>>
> The indentation is a bit skewed here.
> Other than that:
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
>
> Cheers,
>
> Hannes
Agree with Hannes :), please fix this if you post V2.
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxxx>
Thanks
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
