On 10/30/2015 03:53 PM, Benjamin Rood wrote: > If MSI(X) interrupts are disabled via the kernel command line > (pci=nomsi), the pm8001 driver will kernel panic because it does not > detect that MSI interrupts are disabled and will soldier on and attempt to > configure MSI interrupts anyways. This leads to a kernel panic, most > likely because a required data structure is not available down the > line. Using the pci_msi_enabled() function in order to detect if MSI > interrupts are enabled before configuring them resolves this issue and > avoids a kernel panic when the module is loaded. Additionally, the > irq_vector structure must be initialized when legacy interrupts are > being used otherwise legacy interrupts will simply not function and > result in another panic. > > Signed-off-by: Benjamin Rood <brood@xxxxxxxxxxxx> > --- > drivers/scsi/pm8001/pm8001_init.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
