On 10/30/2015 11:49 AM, Gabriel Krisman Bertazi wrote:
> diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h
> index 69257c4..f0238cc 100644
> --- a/drivers/scsi/ipr.h
> +++ b/drivers/scsi/ipr.h
> @@ -849,6 +849,16 @@ struct ipr_inquiry_page0 {
> u8 page[IPR_INQUIRY_PAGE0_ENTRIES];
> }__attribute__((packed));
>
> +struct ipr_inquiry_pageC4 {
> + u8 peri_qual_dev_type;
> + u8 page_code;
> + u8 reserved1;
> + u8 len;
> + u8 cache_cap[4];
> +#define IPR_CAP_SYNC_CACHE 0x08
> + u8 reserved2[20];
> +}__attribute__((packed));
This triggers a couple complaints from checkpatch. You need a space after the },
which checkpatch flags as an error and __packed is preferred to __attribute__((packed)),
which is flagged as a warning. There are a couple of other warnings that checkpatch
issues in this series, so you might want to take a look at them, fixup, and resend.
We should probably spin a follow up patch to fix up the __attribute__ usage in ipr.h,
since you were simply being consistent with that.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
