On 10/28/2015 11:04 PM, Don Brace wrote:
> Check for NULLs.
>
> Signed-off-by: Don Brace <don.brace@xxxxxxxx>
> ---
> drivers/scsi/hpsa.c | 6 ++++++
> drivers/scsi/hpsa.h | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 864fb03..6b6e9bb 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -1139,6 +1139,12 @@ static int hpsa_find_target_lun(struct ctlr_info *h,
> static inline void hpsa_show_dev_msg(const char *level, struct ctlr_info *h,
> struct hpsa_scsi_dev_t *dev, char *description)
> {
> + if (dev == NULL)
> + return;
> +
> + if (h == NULL || h->pdev == NULL || h->scsi_host == NULL)
> + return;
> +
> dev_printk(level, &h->pdev->dev,
> "scsi %d:%d:%d:%d: %s %s %.8s %.16s RAID-%s SSDSmartPathCap%c En%c Exp=%d\n",
> h->scsi_host->host_no, dev->bus, dev->target, dev->lun,
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index 27debb3..d6c4ebf 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -34,7 +34,7 @@ struct access_method {
> };
>
> struct hpsa_scsi_dev_t {
> - int devtype;
> + unsigned int devtype;
> int bus, target, lun; /* as presented to the OS */
> unsigned char scsi3addr[8]; /* as presented to the HW */
> #define RAID_CTLR_LUNID "\0\0\0\0\0\0\0\0"
>
That's not really a check for NULL, isn't it?
Should rather be moved into an individual patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
