On 10/20/2015 10:07 PM, Don Brace wrote: >> -----Original Message----- >> From: Hannes Reinecke [mailto:hare@xxxxxxx] >> Sent: Wednesday, September 30, 2015 2:50 AM >> To: Don Brace; linux-scsi@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH] hpsa: add in sas transport >> >> On 09/30/2015 12:21 AM, Don Brace wrote: >>> From: Kevin Barnett <kevin.barnett@xxxxxxxx> >>> >>> customers want lsscsi -t to show sas addresses when >>> enumerating sas devices. The sas addresses are used >>> mainly to light drive LEDs for location. >>> >>> Signed-off-by: Don Brace <don.brace@xxxxxxxx> >>> --- >>> drivers/scsi/hpsa.c | 704 >> ++++++++++++++++++++++++++++++++++++++++++----- >>> drivers/scsi/hpsa.h | 37 ++ >>> drivers/scsi/hpsa_cmd.h | 14 + >>> 3 files changed, 677 insertions(+), 78 deletions(-) >>> >>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c >>> index 3b35de0..ae811a7 100644 >>> /* Notify scsi mid layer of any added devices */ >>> for (i = 0; i < nadded; i++) { >>> - if (!(added[i]->expose_state & HPSA_SCSI_ADD)) >>> + if (!(added[i]->expose_device)) >>> continue; >>> - if (scsi_add_device(sh, added[i]->bus, >>> - added[i]->target, added[i]->lun) == 0) >>> + if (hpsa_add_device(h, added[i]) == 0) >>> continue; >>> hpsa_show_dev_msg(KERN_WARNING, h, added[i], >>> "addition failed, device not added."); >> Sigh. Here we go again. >> >> I've probably asked you (or Mike Miller :-) about this several times >> now, but couldn't you use the _real_ LUN addresses? >> >> Especially as you're now exposing 'real' devices, where is the point >> of creating an internal LUN mapping table? >> >> If you were expose the devices with the actual LUN address (by eg >> arranging the target/RAID controller on bus '0', the RAID devices on >> bus '1', and the exposed devices on bus '2') you could remove the >> internal LUN mapping table and quite some complexity would go away ... >> > > This can be done. > > However, at this point, I do not want to change hpsa without more testing. > I'll make another patch and send it up after it has a chance to be tested in our labs. > Hope this is OK. > Sure. Just wanted to raise this (again :-), as I think it'd be a good cleanup. > I split out the other changes to separate patches as you recommended. > Please, go ahead. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
