On 10/8/15 4:10 PM, "Julian Calaby" <julian.calaby@xxxxxxxxx> wrote: >Hi James, > >On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley ><James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: >> On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote: >>> >>> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@xxxxxxxxx> wrote: >>> >>> >Hi Xose, >>> > >>> >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez >>> ><xose.vazquez@xxxxxxxxx> wrote: >>> >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby >>> >><julian.calaby@xxxxxxxxx> wrote: >>> >> >>> >>> Some qla2xxx devices have firmware stored in flash on the device, >>> >>> however for debugging and triage purposes, Qlogic staff like to >>> >>> be able to load known-good versions of these firmwares through >>> >>> request_firmware(). >>> >>> >>> >>> These firmware files were never distributed and are unlikely to >>>ever >>> >>> be released publically, so to hide these missing firmware files >>>from >>> >>> scripts which check such things, (e.g. Debian's initramfs-tools) >>>put >>> >>> them behind a new EXPERT Kconfig option. >>> >> >>> >> >>> >> What is state of this patch ? >>> > >>> >Apparently nobody cared, either from qLogic or linux-scsi. >>> > >>> >I'm not overly fussed whether it goes in or not, it was more a point >>> >in the discussion that proceeded it, however it does solve the >>> >problems in the discussion that preceded it. >>> >>> This patch Looks good. >>> >>> Acked-By: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> >> >> Actually, this isn't helpful. You now add another option over which the >> distributions have to make a choice. Is this interface necessary and >> useful? If yes, then it should be compiled in and if not, just remove >> it ... don't do death by 1000 Kconfig options. > >The original issue here was that the qla2xxx driver specifies two >firmware files which are not publicly available. > >They aren't publicly available because the hardware that uses them >always stores it's firmware in flash. > >The firmware files are specified in the driver because qLogic support >likes to be able to load a known-good firmware file from disk for >debugging faulty hardware. > >Some distributions (Debian is a good example) will complain vocally >about missing firmware files when installing kernels or producing >initramfs images. > >This patch was intended as an ugly compromise between all of this. Julian, James, We will send a patch to remove such references in our driver. -- Giri > >Thanks, > >-- >Julian Calaby > >Email: julian.calaby@xxxxxxxxx >Profile: http://www.google.com/profiles/julian.calaby/
<<attachment: winmail.dat>>
