On 10/01/2015 11:06 PM, Hannes Reinecke wrote:
On 10/02/2015 02:07 AM, Bart Van Assche wrote:
The old implementation calls the callback function 'fn' if the flag
TPGS_MODE_EXPLICIT has not been set but the new implementation not.
Please mention this in the patch description if this behavior change
is intentional.
Actually, this looks more like an error with the old implementation.
'fn' is the callback signalling that the failover command has been
completed, and the caller (in most case dm-multipath) relies on 'fn'
to be executed for further processing.
So 'fn' should be executed, irrespective of the TPGS_MODE_EXPLICIT flag.
Thank you for the feedback. I think reviewers would be grateful if this
change would be documented in the patch description.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
