On Fri, Oct 02, 2015 at 03:09:33PM +0200, Johannes Thumshirn wrote: > Having the list_move() outside of the host_lock was purely by > accident. Interestingly the stressing didn't mind it. But yes you're > right, __scsi_remove_target() should be made host_lock() save for being > called under the host_lock. > > Regarding the list move, does it look OK for you (i.e. do we still need > it after reworking __scsi_remove_target())? IMHO yes, but I only have > half a year of experience in this area). Hi Johannes, your general approach looks fine, we just need to fix up the locking as far as I can tell. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html