Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes:
> This saves a little .text and avoids the sizeof(...) style
> inconsistency.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/scsi/fnic/fnic_fcs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
> index bf0bbd42efb5..2d013076bfba 100644
> --- a/drivers/scsi/fnic/fnic_fcs.c
> +++ b/drivers/scsi/fnic/fnic_fcs.c
> @@ -415,15 +415,13 @@ static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *skb)
> vid = ntohs(((struct fip_vlan_desc *)desc)->fd_vlan);
> shost_printk(KERN_INFO, fnic->lport->host,
> "process_vlan_resp: FIP VLAN %d\n", vid);
> - vlan = kmalloc(sizeof(*vlan),
> - GFP_ATOMIC);
> + vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC);
> if (!vlan) {
> /* retry from timer */
> spin_unlock_irqrestore(&fnic->vlans_lock,
> flags);
> goto out;
> }
> - memset(vlan, 0, sizeof(struct fcoe_vlan));
> vlan->vid = vid & 0x0fff;
> vlan->state = FIP_VLAN_AVAIL;
> list_add_tail(&vlan->list, &fnic->vlans);
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
