On Thu, Oct 1, 2015 at 6:01 PM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote:
>> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
>> index 7a6dbfb..0b87abb 100644
>> --- a/drivers/scsi/be2iscsi/be_main.c
>> +++ b/drivers/scsi/be2iscsi/be_main.c
>> @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
>> {
>> WARN_ON(!virtual_address);
>> WARN_ON(!physical_address);
>> - WARN_ON(!length > 0);
>> + WARN_ON(!(length > 0));
>
> Why aren't you doing WARN_ON(length <= 0); it's much nicer to read IMHO
Sure, I'll resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
