sd_done and WRITE_SAME broken?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



drivers/scsi/sd.c

1706                 if (sshdr.asc == 0x20 || sshdr.asc == 0x24) {
1707                         switch (op) {
1708                         case UNMAP:
1709                                 sd_config_discard(sdkp, SD_LBP_DISABLE);
1710                                 break;
1711                         case WRITE_SAME_16:
1712                         case WRITE_SAME:
1713                                 if (unmap)
1714                                         sd_config_discard(sdkp,
SD_LBP_DISABLE);
1715                                 else {
1716                                         sdkp->device->no_write_same = 1;
1717                                         sd_config_write_same(sdkp);
1718
1719                                         good_bytes = 0;
1720                                         req->__data_len =
blk_rq_bytes(req);
1721                                         req->cmd_flags |= REQ_QUIET;
1722                                 }
1723                         }
1724                 }

line 1720 is assigning the same value to same field in same req.
That's probably not what was intended but I don't know what is needed
here.

cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux