Re: [PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sep 17, 2015, at 8:26 PM, Brian King <brking@xxxxxxxxxxxxxxxxxx> wrote:
> 
> On 09/16/2015 04:27 PM, Matthew R. Ochs wrote:
>> 
>> 	lun_access = kzalloc(sizeof(*lun_access), GFP_KERNEL);
>> 	if (unlikely(!lun_access)) {
>> 		dev_err(dev, "%s: Unable to allocate lun_access!\n", __func__);
>> +		scsi_device_put(sdev);
> 
> Looks like you've got a double scsi_device_put in this path, since there is another put
> in the the err0 path.

Good catch! I'll fix in v3.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux