On 16/09/2015 16:23, Christoph Hellwig wrote: > > I'm trying to cater to the objections that were made to Andy's patch. > > If you mean the non-UAPI headers, James wanted them to stay in scsi/; if > > you mean the UAPI headers, Douglas complained about the flat structure > > of include/linux/. > > Yes, keep the non-UAPI ones as is and move the UAPI ones to linux/ - the flat > structure is a feature, not a bug. > > > > Also scsi/scsi.h has some additional ioctl defintions that should be > > > added to the UAPI scsi_ioctl.h. Otherwise this looks ok to me. > > > > I can do this, but I think they are obsoleted by SG_GET_SCSI_ID, except > > for SCSI_IOCTL_GET_PCI which is horrible anyway. :) The comment about > > conflicts with CDROM ioctls is also interesting. I can see why one > > would want to keep them out of the new canonical place for SCSI ioctls. > > No point in hiding them. We can still officially deprecate them, but I'd > much rather have them in a single place than hidden away somewhere. Ok, will do both. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
