On 08/31/2015 10:48 PM, James Smart wrote:
>
> From: Bodo Stroesser <bstroesser@xxxxxxxxxxxxxx>
>
> Hi James,
>
> We had some performance problems with RAID systems connected to LPe12k.
> AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to
> be smaller than expected.
>
> The patch below fixes it for us.
>
> Please CC me, I'm not on the list.
>
> Best regards
> Bodo
>
> ------------------------------------------------------
>
> Currently the module parameter lpfc_sg_seg_count does not have effect
> for sli3 devices.
>
> In lpfc_sli_driver_resource_setup(), which is used for sli3, the code
> writes the configured sg_seg_cnt into lpfc_template.sg_tablesize.
> But lpfc_template is the template used for sli4 only. Thus the value should
> correctly be written to lpfc_template_s3->sg_tablesize.
>
> This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only.
>
> Signed-off-by: Bodo Stroesser <bstroesser@xxxxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxxx>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index da9b6fc..81bfb2d 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4994,7 +4994,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
>
> /* Initialize the host templates the configured values. */
> lpfc_vport_template.sg_tablesize = phba->cfg_sg_seg_cnt;
> - lpfc_template.sg_tablesize = phba->cfg_sg_seg_cnt;
> + lpfc_template_s3.sg_tablesize = phba->cfg_sg_seg_cnt;
>
> /* There are going to be 2 reserved BDEs: 1 FCP cmnd + 1 FCP rsp */
> if (phba->cfg_enable_bg) {
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
