On 09/06/2015 12:32 AM, Sagi Grimberg wrote: > On 9/5/2015 11:44 PM, Lee Duncan wrote: >> This is an updated version of a patch I submitted a few days ago. >> >> The previous versions of this patch updated the scsi hosts module >> to use the ida helper routines to allocate host numbers, instead >> of using a simple integer. >> >> Based on a suggestion by Christoph Hellwig, I decided to use the >> idr helper routines instead of the ida set, since the idr functions >> can also associate a pointer with an index. > > While we're at it, why not include sd index conversion? > I'm not sure what you mean here. Are you suggesting sd.c be updated to use idr index routines instead of ida routines so that sd.c could associate instance pointers with instance numbers, much like I did for hosts.c? If so, looking over sd.c, I don't think that would be feasible. The sd.c driver does not do any searches for a pointer based on the index number. Could you be more specific? And do you have any objections to this patch? -- Lee Duncan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
