On 09/01/2015 12:04 PM, Christoph Hellwig wrote: > On Thu, Aug 27, 2015 at 02:41:09PM +0200, Hannes Reinecke wrote: >> We should be issuing STPG synchronously as we need to >> evaluate the return code on failure. > > This looks right, but I think the patch needs to be split and needs > a way better changelog. > > patch 1: > - factor out the alua_stpg helper > > patch 2: > - async STPG > - please explain that alua_activate will now block and why this is ok > > patch 3: > - add the new call to alua_rtpg and why it's added > Okay, will be doing so with the next round. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
