On 09/01/2015 12:22 PM, Christoph Hellwig wrote: > On Thu, Aug 27, 2015 at 02:41:14PM +0200, Hannes Reinecke wrote: >> Add a function scsi_vpd_lun_id() to return a unique device >> identifcation based on the designation descriptors of >> VPD page 0x83. >> >> As devices might implement several descriptors the order >> of preference is: >> - NAA IEE Registered Extended >> - EUI-64 based 16-byte >> - EUI-64 based 12-byte >> - NAA IEEE Registered >> - NAA IEEE Extended >> A SCSI name string descriptor is preferred to all of them >> if the identification is longer than 16 bytes. >> >> The returned unique device identification will be formatted >> as a SCSI Name string to avoid clashes between different >> designator types. > > Looks good in general, but I wonder if it might make sense to switch > to kasprintf and let the caller free the buffer? > I really am no friend of caller-needs-to-free-up-buffer thingies. Allocations and deallocations should be done in the same context for better tracking (and debugging), IMO. > Otherwise: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
