> -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] > Sent: Monday, August 31, 2015 7:02 AM > To: KY Srinivasan <kys@xxxxxxxxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; ohering@xxxxxxxx; > jbottomley@xxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; > apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx; jasowang@xxxxxxxxxx; > stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/1] storvsc: Don't set the > SRB_FLAGS_QUEUE_ACTION_ENABLE flag > > On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not > specifying > > tags. > > What's the actual problem description this causes? Qlogic driver does not work correctly if the SRB_FLAGS_QUEUE_ACTION_ENABLE is set and no action tag is specified. Regards, K. Y > > James > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > --- > > drivers/scsi/storvsc_drv.c | 3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > > index 40c43ae..ad8c4bc 100644 > > --- a/drivers/scsi/storvsc_drv.c > > +++ b/drivers/scsi/storvsc_drv.c > > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct > Scsi_Host *host, struct scsi_cmnd *scmnd) > > vm_srb->win8_extension.time_out_value = 60; > > > > vm_srb->win8_extension.srb_flags |= > > - (SRB_FLAGS_QUEUE_ACTION_ENABLE | > > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER; > > > > /* Build the SRB */ > > switch (scmnd->sc_data_direction) { > > ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
