Hi Christoph, Hi Tomas, After discussed internally, this driver patch is required only if "auto commit" support is not available in the controller firmware. We have fix in the released controller firmware, so this driver patch is not needed. I'm removing this patch in V7. Hi James, As you suggested, will keep the review-tags going V6->V7 and add reviewers in CC list. Thanks, Mahesh -----Original Message----- From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] Sent: Tuesday, August 25, 2015 8:41 PM To: Tomas Henzl Cc: Mahesh Rajashekhara; JBottomley@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; aacraid@xxxxxxxxxxxxxx; Harry Yang; Rich Bono Subject: Re: [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware On Tue, Aug 25, 2015 at 04:57:26PM +0200, Tomas Henzl wrote: > On 11.8.2015 07:58, Mahesh Rajashekhara wrote: > > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) > > + aac_get_config_status(aac, 1); > > +#else > > aac_get_config_status(aac, 0); > > +#endif > > If we use instead > + aac_get_config_status(aac, 1); > on all archs will it make problems ? Yes, that should be our first choice. If that doesn't work it should be a #ifndef CONFIG_X86 with a comment explaining it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
