On Tue, 30 Jun 2015, Rudhresh Kumar J wrote:
> Fixed coding style issue by adding KERN_ facility level to some of
> the printk functions.
>
> Signed-off-by: Rudhresh Kumar J <rudhresh.jk@xxxxxxxxx>
> ---
> drivers/scsi/dtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..a3a2a71 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -156,7 +156,7 @@ static int __init dtc_setup(char *str)
>
> get_options(str, ARRAY_SIZE(ints), ints);
> if (ints[0] != 2)
> - printk("dtc_setup: usage dtc=address,irq\n");
> + printk(KERN_DEBUG "dtc_setup: usage dtc=address,irq\n");
No, that is an error message that the user needs to see.
> else if (commandline_current < NO_OVERRIDES) {
> overrides[commandline_current].address = ints[1];
> overrides[commandline_current].irq = ints[2];
> @@ -272,7 +272,7 @@ found:
> instance->irq = NO_IRQ;
> #endif
> #if defined(DTCDEBUG) && (DTCDEBUG & DTCDEBUG_INIT)
> - printk("scsi%d : irq = %d\n", instance->host_no, instance->irq);
> + printk(KERN_DEBUG "scsi%d : irq = %d\n", instance->host_no, instance->irq);
> #endif
>
> ++current_override;
>
I have a better patch for this, which makes use of the dprintk macro to
replace {DTC,P,T}DEBUG_INIT with NDEBUG_INIT. Thanks anyway.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
