Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you Mita for the review.
Your comments were correct and helpful.
I appreciate your time and effort.

please see inline.

> 2015-08-16 19:14 GMT+09:00 Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>:
>> @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops
>> ufs_hba_qcom_vops = {
>>         .resume                 = ufs_qcom_resume,
>>         .dbg_register_dump      = ufs_qcom_dump_dbg_regs,
>>  };
>> +EXPORT_SYMBOL(ufs_hba_qcom_vops);
>
> As I said in the view comment for the patch 5, this shouldn't be exported
> again.

I removed this export at all. it is not needed anymore.

>
>> @@ -775,6 +781,12 @@ static inline int ufshcd_vops_resume(struct ufs_hba
>> *hba, enum ufs_pm_op op)
>>         return 0;
>>  }
>>
>> +static inline void ufshcd_vops_dbg_register_dump(struct ufs_hba *hba)
>> +{
>> +       if (hba->vops && hba->vops->dbg_register_dump)
>> +               hba->vops->dbg_register_dump(hba);
>> +}
>> +
>
> This change should be done in the patch 7?

you are correct.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux