> On Aug 14, 2015, at 3:35 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The > should be >= or we read one element past the end of the array.
Dan - Good catch!
Acked-by: Matthew R. Ochs <mrochs@xxxxxxxxxxxxxxxxxx>
>
> Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter')
> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
> index 0720d2f..fd70101 100644
> --- a/drivers/scsi/cxlflash/main.c
> +++ b/drivers/scsi/cxlflash/main.c
> @@ -539,7 +539,7 @@ static ssize_t cxlflash_show_port_status(struct device *dev,
> u64 *fc_regs;
>
> rc = kstrtouint((attr->attr.name + 4), 10, &port);
> - if (rc || (port > NUM_FC_PORTS))
> + if (rc || (port >= NUM_FC_PORTS))
> return 0;
>
> fc_regs = &afu->afu_map->global.fc_regs[port][0];
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
