Mikey:
Thanks for pointing this out. The patch for 2/3 should address this
issue.
Regards,
- Manoj Kumar
On 8/13/2015 8:08 PM, Michael Neuling wrote:
On Thu, 2015-08-13 at 18:43 -0500, Manoj Kumar wrote:
Mikey:
Thanks for your review. See comment inline below.
- Manoj Kumar
On 8/13/2015 7:03 AM, Michael Neuling wrote:
Thanks for integrating my suggestions. create_context() has the same
freeing bug as 2/3 but if you fix that I'm happy if you add my
reviewed by:
Reviewed-by: Michael Neuling <mikey@xxxxxxxxxxx>
I believe create_context() is in 2/3, not here. I did not find the same
issue in this patch.
This is the section I referring to from this patch. Seems to be
building on the 2/3 issue.
@@ -693,11 +737,13 @@ static struct ctx_info *create_context(struct cxlflash_cfg *cfg,
struct afu *afu = cfg->afu;
struct ctx_info *ctxi = NULL;
struct llun_info **lli = NULL;
+ bool *ws = NULL;
struct sisl_rht_entry *rhte;
ctxi = kzalloc(sizeof(*ctxi), GFP_KERNEL);
lli = kzalloc((MAX_RHT_PER_CONTEXT * sizeof(*lli)), GFP_KERNEL);
- if (unlikely(!ctxi || !lli)) {
+ ws = kzalloc((MAX_RHT_PER_CONTEXT * sizeof(*ws)), GFP_KERNEL);
+ if (unlikely(!ctxi || !lli || !ws)) {
dev_err(dev, "%s: Unable to allocate context!\n", __func__);
goto out;
This will be changed to 'goto err' by the v6 patch 2/3.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
