Hi Johannes, On 08/12/2015 01:42 PM, Johannes Thumshirn wrote: > hmmm, how about > > goto free_skb; >> + } >> + >> fnic_queue_rq_desc(rq, skb, pa, len); >> - return 0; >> +err: > > free_skb: > kfree_skb(skb); > >> + return r; >> } > > Although the return is near to the error handling, it's preferred to > have the labels named after the action that is taken there. Ok, I'll post a V2 of this patch soon, thanks for the review. Regards, Maurizio Lombardi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
