> -----Original Message----- > From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx] > Sent: Wednesday, August 12, 2015 7:29 AM > To: Sumit.Saxena@xxxxxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; thenzl@xxxxxxxxxx; > martin.petersen@xxxxxxxxxx; hch@xxxxxxxxxxxxx; jbottomley@xxxxxxxxxxxxx; > kashyap.desai@xxxxxxxxxxxxx; kiran-kumar.kasturi@xxxxxxxxxxxxx; > uday.lingala@xxxxxxxxxxxxx > Subject: Re: [PATCH 2/7] megaraid_sas : Support for max_io_size 1MB > > > Sumit, > > @@ -1239,7 +1239,9 @@ union megasas_sgl_frame { typedef union > _MFI_CAPABILITIES { > struct { > #if defined(__BIG_ENDIAN_BITFIELD) > - u32 reserved:25; > + u32 reserved:23; > + u32 support_ext_io_size:1; > + u32 support_ext_queue_depth:1; > u32 security_protocol_cmds_fw:1; > u32 support_core_affinity:1; > u32 support_ndrive_r1_lb:1; > @@ -1255,7 +1257,9 @@ typedef union _MFI_CAPABILITIES { > u32 support_ndrive_r1_lb:1; > u32 support_core_affinity:1; > u32 security_protocol_cmds_fw:1; > - u32 reserved:25; > + u32 support_ext_queue_depth:1; > + u32 support_ext_io_size:1; > + u32 reserved:23; > #endif > } mfi_capabilities; > __le32 reg; > > Mystery field: support_ext_queue_depth. This is added to keep driver and firmware API naming in sync, will create separate patch for syncing drivers and firmware APIs changes. > > - fusion->sg_dma_pool = pci_pool_create("megasas sg pool fusion", > - instance->pdev, > - total_sz_chain_frame, 4, > - 0); > + fusion->sg_dma_pool = pci_pool_create("sg_pool_fusion", instance- > >pdev, > + instance- > >max_chain_frame_sz, > + 4, 0); > + > > Why rename the pools? I don't particularly mind but megasas is probably more > descriptive for most users than fusion is. There are two types of controllers megasas drivers support- 1)MFI controllers 2)Fusion controllers so used "fusion" name here. > > @@ -1096,15 +1093,40 @@ megasas_init_adapter_fusion(struct > megasas_instance *instance) > (MEGA_MPI2_RAID_DEFAULT_IO_FRAME_SIZE * > (max_cmd + 1)); /* Extra 1 for SMID 0 */ > > + scratch_pad_2 = readl(&instance->reg_set->outbound_scratch_pad_2); > > scratch_pad_2 sounds like a pretty temporary thing rather than an officially > exported interface. But I guess that's what it's called. Correct. > > + /* If scratch_pad_2 & MEGASAS_MAX_CHAIN_SIZE_UNITS_MASK is set, > + * Firmware support extended IO chain frame which is 4 time more > > Nitpick: s/time/times/ Will rectify this:) > > + if (scratch_pad_2 & MEGASAS_MAX_CHAIN_SIZE_UNITS_MASK) > + instance->max_chain_frame_sz = > + ((scratch_pad_2 & MEGASAS_MAX_CHAIN_SIZE_MASK) > >> 5) > + * MEGASAS_1MB_IO; > > Magic number 5. Please define MEGASAS_MAX_CHAIN_SHIFT and use that. Agree..will do this. > > @@ -117,7 +121,9 @@ struct RAID_CONTEXT { > u8 numSGE; > __le16 configSeqNum; > u8 spanArm; > - u8 resvd2[3]; > + u8 priority; > + u8 numSGEExt; /* 0x1E 1M IO support */ > + u8 resvd2; /* 0x1F */ > }; > > Mystery priority addition. Again this is to keep driver and firmware APIs in sync and will do all such changes in separate patch. > > -- > Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
