Currently SNIC_HOST_ERR is called in both cases whether snic_disc_start returns zero or non-zero. >From the code it looks like it has to print only if snic_disc_start return non-zero value, So calling SNIC_HOST_ERR only for non-zero return from snic_disc_start. Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx> Reviewed-by: Rohit Thapliyal <r.thapliyal@xxxxxxxxxxx> --- drivers/scsi/snic/snic_disc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/snic/snic_disc.c b/drivers/scsi/snic/snic_disc.c index 5f63217..8c29d5e 100644 --- a/drivers/scsi/snic/snic_disc.c +++ b/drivers/scsi/snic/snic_disc.c @@ -514,12 +514,9 @@ snic_handle_disc(struct work_struct *work) ret = snic_disc_start(snic); if (ret) - goto disc_err; - -disc_err: - SNIC_HOST_ERR(snic->shost, - "disc_work: Discovery Failed w/ err = %d\n", - ret); + SNIC_HOST_ERR(snic->shost, + "disc_work: Discovery Failed w/ err = %d\n", + ret); } /* end of snic_disc_work */ /* -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
