On Tue, Jun 23, 2015 at 08:11:00AM +0000, Seymour, Shane M wrote: > This patch changes the st driver to use attribute groups so > driver sysfs files are created automatically. See the > following for reference: > > http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ > > Signed-off-by: Shane Seymour <shane.seymour@xxxxxx> Very nice, thanks for doing this. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > --- a/drivers/scsi/st.c 2015-06-22 14:20:40.829612661 -0500 > +++ b/drivers/scsi/st.c 2015-06-22 15:49:49.357248393 -0500 > @@ -85,6 +85,7 @@ static int debug_flag; > > static struct class st_sysfs_class; > static const struct attribute_group *st_dev_groups[]; > +static const struct attribute_group *st_drv_groups[]; > > MODULE_AUTHOR("Kai Makisara"); > MODULE_DESCRIPTION("SCSI tape (st) driver"); > @@ -198,15 +199,13 @@ static int sgl_unmap_user_pages(struct s > static int st_probe(struct device *); > static int st_remove(struct device *); > > -static int do_create_sysfs_files(void); > -static void do_remove_sysfs_files(void); > - > static struct scsi_driver st_template = { > .gendrv = { > .name = "st", > .owner = THIS_MODULE, > .probe = st_probe, > .remove = st_remove, > + .groups = st_drv_groups, > }, > }; > > @@ -4404,14 +4403,8 @@ static int __init init_st(void) > if (err) > goto err_chrdev; > > - err = do_create_sysfs_files(); > - if (err) > - goto err_scsidrv; > - > return 0; > > -err_scsidrv: > - scsi_unregister_driver(&st_template.gendrv); > err_chrdev: > unregister_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0), > ST_MAX_TAPE_ENTRIES); > @@ -4422,7 +4415,6 @@ err_class: > > static void __exit exit_st(void) > { > - do_remove_sysfs_files(); > scsi_unregister_driver(&st_template.gendrv); > unregister_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0), > ST_MAX_TAPE_ENTRIES); > @@ -4459,44 +4451,14 @@ static ssize_t st_version_show(struct de > } > static DRIVER_ATTR(version, S_IRUGO, st_version_show, NULL); For a future patch, you might want to convert these type of declarations to use DRIVER_ATTR_RO() and friends. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
