On 06/19/2015 03:07 PM, Christoph Hellwig wrote:
>> + hlist_for_each_entry_rcu(tmp, &nacl->lun_entry_hlist, link) {
>> + if (tmp == new)
>> + continue;
>> + core_scsi3_ua_allocate(tmp, 0x3F,
>> + ASCQ_3FH_REPORTED_LUNS_DATA_HAS_CHANGED);
>> + }
>> + rcu_read_unlock();
>> +
>
>> + rcu_read_lock();
>> + hlist_for_each_entry_rcu(tmp, &nacl->lun_entry_hlist, link) {
>> + if (tmp == new)
>> + continue;
>> + core_scsi3_ua_allocate(tmp, 0x3F,
>> + ASCQ_3FH_REPORTED_LUNS_DATA_HAS_CHANGED);
>> + }
>> + rcu_read_unlock();
>
>> +
>> + rcu_read_lock();
>> + hlist_for_each_entry_rcu(tmp, &nacl->lun_entry_hlist, link)
>> + core_scsi3_ua_allocate(tmp, 0x3F,
>> + ASCQ_3FH_REPORTED_LUNS_DATA_HAS_CHANGED);
>> + rcu_read_unlock();
>
> Please add a helper instead of duplicating this three times.
>
Okay.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
