Re: [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James, 

      Thanks for fixing the errors. the check patch that I used didn¹t
list them as error, probably a lower version.

Thank you very much for mentoring.

Thanks
Narsimhulu

On 13/06/15 9:47 pm, "James Bottomley"
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:

>On Fri, 2015-05-29 at 01:04 -0700, Narsimhulu Musini wrote:
>> +static const struct file_operations snic_stats_fops __read_mostly = {
>> +	.owner	= THIS_MODULE,
>> +	.open	= snic_stats_open,
>> +	.read	= seq_read,
>> +	.llseek = seq_lseek,
>> +	.release = single_release,
>> +};
>
>Checkpatch hates this for obvious reasons: a const structure has to be
>read only, not read mostly, so it's a section conflict.  I fixed it up,
>but running the code through checkpatch would have flagged it as an
>error.
>
>James
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux