2015-06-08 0:32 GMT+09:00 <ygardi@xxxxxxxxxxxxxx>: > 1) > If ufshcd-pltfrm driver is loaded before ufs-qcom, (what actually happens > always), then the calling to of_platform_populate() which is added, > guarantees that ufs-qcom probe will be called and finish, before > ufshcd_pltfrm probe continues. I'm worrying the case ufshcd_pltfrm_probe() is called when ufshcd-pltfrm module is installed but ufs-qcom module is _not_ installed yet, where ufshcd-pltfrm and ufs-qcom are both built as loadable modules. In this case, of_platform_populate() in ufshcd_pltfrm_probe() doesn't invoke ufs-qcom probe, does it? So I suggested using deferred probe infrastructure by returning -EPROBE_DEFER. > so ufs_variant device is always there, and ready. > I think it means we are safe - since either way, we make sure ufs-qcom > probe will be called and finish before dealing with ufs_variant device in > ufshcd_pltfrm probe. > > 2) you are right. the fix added as you suggested. Thanks for fixing it. But a little more work is needed in v3, I'll leave a comment to v3. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
