On 05/11/2015 08:48 AM, Christoph Hellwig wrote: >> @@ -352,55 +315,42 @@ static int alua_check_tpgs(struct scsi_device *sdev, struct alua_dh_data *h) >> sdev_printk(KERN_INFO, sdev, "%s: supports implicit TPGS\n", >> ALUA_DH_NAME); >> break; >> - default: >> - h->tpgs = TPGS_MODE_NONE; >> + case TPGS_MODE_NONE: >> sdev_printk(KERN_INFO, sdev, "%s: not supported\n", >> ALUA_DH_NAME); >> err = SCSI_DH_DEV_UNSUPP; >> break; >> + default: >> + sdev_printk(KERN_INFO, sdev, >> + "%s: unsupported TPGS setting %d\n", >> + ALUA_DH_NAME, h->tpgs); >> + h->tpgs = TPGS_MODE_NONE; >> + err = SCSI_DH_DEV_UNSUPP; >> + break; > > Can you split this into a separate patch, please? > > Otherwise looks fine, so: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > for both resulting patches. > Okay, will do. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
